Compare DS job: store PR info to be used by compare ds workflow#14282
Compare DS job: store PR info to be used by compare ds workflow#14282Mab879 merged 1 commit intoComplianceAsCode:masterfrom
Conversation
Mab879
left a comment
Mab879
left a comment
There was a problem hiding this comment.
We change want to change the name to be unique.
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| run-id: ${{ github.event.workflow_run.id }} | ||
| name: pr-info |
There was a problem hiding this comment.
This is the same name as ATEX, I think we might run into issues here.
There was a problem hiding this comment.
so, I also had the same doubt, but apparently the github workflow knows how to distinguish which artifact to download by using the run-id attribute, which is somehow described here: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#using-data-from-the-triggering-workflow
it knows from which workflow triggered the workflow_run and thus knows which artifact to download. That was my assumption. What do you think?
There was a problem hiding this comment.
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
|
@Mab879 it seems that my changes worked but for some reason the artifacts with the head sha didn't work, see: https://github.com/ComplianceAsCode/content/actions/runs/20835543123/job/59859380718 we probably just need to remove the head sha from the artifact id and it should work. |
2 participants
Description:
Rationale:
Review Hints: